<html>
<head><meta charset="utf-8"><title>rustc tests · t-compiler/wg-polonius · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/186049-t-compiler/wg-polonius/index.html">t-compiler/wg-polonius</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/186049-t-compiler/wg-polonius/topic/rustc.20tests.html">rustc tests</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="205994295"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/186049-t-compiler/wg-polonius/topic/rustc%20tests/near/205994295" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/186049-t-compiler/wg-polonius/topic/rustc.20tests.html#205994295">(Aug 05 2020 at 07:12)</a>:</h4>
<p>today (it's already the last day of the sprint <span aria-label="scream" class="emoji emoji-1f631" role="img" title="scream">:scream:</span>) I'll start with looking at the test suite failures and updating the <a href="https://hackmd.io/CjYB0fs4Q9CweyeTdKWyEg?view">hackmd report</a></p>



<a name="205994385"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/186049-t-compiler/wg-polonius/topic/rustc%20tests/near/205994385" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/186049-t-compiler/wg-polonius/topic/rustc.20tests.html#205994385">(Aug 05 2020 at 07:14)</a>:</h4>
<p>I'll also try to point out the weird cases I mentioned before, just to get a few more eyes on them, and be a bit more certain if they're because of work to be done in the future (specifically, requiring chalk integration) or if they're just bugs</p>



<a name="206004007"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/186049-t-compiler/wg-polonius/topic/rustc%20tests/near/206004007" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/186049-t-compiler/wg-polonius/topic/rustc.20tests.html#206004007">(Aug 05 2020 at 09:38)</a>:</h4>
<p>(I got distracted with instrumenting our computation steps and datalog rules so I'll actually start on this after lunch)</p>



<a name="206027051"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/186049-t-compiler/wg-polonius/topic/rustc%20tests/near/206027051" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/186049-t-compiler/wg-polonius/topic/rustc.20tests.html#206027051">(Aug 05 2020 at 14:16)</a>:</h4>
<p>this one is a cool "failure" <a href="https://github.com/rust-lang/rust/blob/master/src/test/ui/closures/closure-expected-type/expect-region-supply-region-2.rs">https://github.com/rust-lang/rust/blob/master/src/test/ui/closures/closure-expected-type/expect-region-supply-region-2.rs</a></p>



<a name="206027085"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/186049-t-compiler/wg-polonius/topic/rustc%20tests/near/206027085" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/186049-t-compiler/wg-polonius/topic/rustc.20tests.html#206027085">(Aug 05 2020 at 14:17)</a>:</h4>
<p>cool because of <code>// Borrowck doesn't get a chance to run, but if it did it should error here.</code> as polonius sees the error</p>



<a name="206029120"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/186049-t-compiler/wg-polonius/topic/rustc%20tests/near/206029120" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Amanda Stjerna <a href="https://rust-lang.github.io/zulip_archive/stream/186049-t-compiler/wg-polonius/topic/rustc.20tests.html#206029120">(Aug 05 2020 at 14:34)</a>:</h4>
<p>Cool!</p>



<a name="206171876"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/186049-t-compiler/wg-polonius/topic/rustc%20tests/near/206171876" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/186049-t-compiler/wg-polonius/topic/rustc.20tests.html#206171876">(Aug 06 2020 at 17:30)</a>:</h4>
<p>I've completed my first pass at the new failures and have updated the document. Most are benign changes to the test output needing and update, or a new test added since the last time we put up a PR for the test expectations</p>



<a name="206172165"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/186049-t-compiler/wg-polonius/topic/rustc%20tests/near/206172165" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/186049-t-compiler/wg-polonius/topic/rustc.20tests.html#206172165">(Aug 06 2020 at 17:32)</a>:</h4>
<p>apart from that, <a href="https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-26217.rs">https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-26217.rs</a> now fails, which is expected, but I don't understand why it fails <em>now</em>, the test is old, has NLL expectations, I would have expected it to fail earlier. Maybe some recent changes (maybe the leak check ones) had an impact here but I don't know. It's weird but probably not that important ?</p>



<a name="206172397"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/186049-t-compiler/wg-polonius/topic/rustc%20tests/near/206172397" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/186049-t-compiler/wg-polonius/topic/rustc.20tests.html#206172397">(Aug 06 2020 at 17:34)</a>:</h4>
<p>and this one <a href="https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-74564-if-expr-stack-overflow.rs">https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-74564-if-expr-stack-overflow.rs</a> (with a very big MIR if expression) doesn't terminate or is extremely slow, somewhere in polonius (not during fact generation, which takes a long while but completes). I haven't checked yet where exactly in the process this happens but I'll look at it next.</p>



<a name="206173636"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/186049-t-compiler/wg-polonius/topic/rustc%20tests/near/206173636" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/186049-t-compiler/wg-polonius/topic/rustc.20tests.html#206173636">(Aug 06 2020 at 17:44)</a>:</h4>
<p>fact generation is slow because the CFG has 183K edges, and 2 origins equal at all points of the cfg</p>



<a name="206178914"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/186049-t-compiler/wg-polonius/topic/rustc%20tests/near/206178914" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/186049-t-compiler/wg-polonius/topic/rustc.20tests.html#206178914">(Aug 06 2020 at 18:28)</a>:</h4>
<p>ah it's somewhere in move errors, I killed the test after 20mins</p>



<a name="206180185"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/186049-t-compiler/wg-polonius/topic/rustc%20tests/near/206180185" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/186049-t-compiler/wg-polonius/topic/rustc.20tests.html#206180185">(Aug 06 2020 at 18:39)</a>:</h4>
<p>and this time, unlike clap, we can't just disable move errors, as <code>var_maybe_partly_initialized_on_exit</code> also seems to grow or loop</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>